Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra constant fix #16

Merged
merged 6 commits into from
Jun 23, 2019
Merged

Extra constant fix #16

merged 6 commits into from
Jun 23, 2019

Conversation

devkabiir
Copy link
Contributor

This will fix the bug when

@GET('/list')
@dio.Extra({'my_key': CustomValue()}
Future<void> list();

Produces the extra variable with null values

const _extra = <String, dynamic>{'key':null};

This will fix it and produce correct output

const _extra = <String, dynamic>{'key': CustomValue()};

Also added test cases for this

@devkabiir
Copy link
Contributor Author

@trevorwang You should add dart: stable in Travis config and also run pub run test.

@trevorwang trevorwang merged commit 57b1969 into trevorwang:master Jun 23, 2019
@trevorwang
Copy link
Owner

@devkabiir Will enable in another commit

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants