Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage for handshakesettings and few fixes #88

Merged
merged 4 commits into from
Mar 24, 2015
Merged

Test coverage for handshakesettings and few fixes #88

merged 4 commits into from
Mar 24, 2015

Conversation

tomato42
Copy link
Contributor

  • promote the methods used externally to public
  • provide test coverage for whole class
  • add a check for minKeySize vs maxKeySize

@tomato42
promote HandshakeSettings._filter() to public
51b5bce 
since the _filter is used outside its class, it should be
a public method. The `filter` is a reserved word though, so
rename the method to `validate()`.
@tomato42
unit tests for HandshakeSettings
b18fbf3
@tomato42
add check for interdependance of minKeySize and maxKeySize
6f6f2ac
@tomato42
promote HandshakeSettings._getCertificateTypes to public
a9f92d4 
the method is only used by external classes so it should be public
@tomato42 tomato42 changed the title Test coverage for handshakesettings and few fixes fixes Test coverage for handshakesettings and few fixes Mar 24, 2015
@tomato42
Copy link
Contributor Author

@trevp: one task on travis seems to have hung, you should be able to reschedule it as the owner

trevp added a commit that referenced this pull request Mar 24, 2015
@trevp
Merge pull request #88 from tomato42/handshakesettings-fixes
e4604fa 
Test coverage for handshakesettings and few fixes
@trevp trevp merged commit e4604fa into trevp:master Mar 24, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+1.32%) to 42.17% when pulling a9f92d4 on tomato42:handshakesettings-fixes into 02c41b8 on trevp:master.

@tomato42 tomato42 deleted the handshakesettings-fixes branch March 24, 2015 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomato42 @coveralls @trevp