Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Japanese delimiter bug #110

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Fix Japanese delimiter bug #110

merged 5 commits into from
Jun 29, 2023

Conversation

LucienSong
Copy link
Contributor

Fix Japanese delimiter bug.
And add Czech and Portuguese wordlist.

Add Czech and Portuguese wordlist.
Fix Japanese delimiter bug.
Fix Japanese delimiter bug
@LucienSong
Copy link
Contributor Author

When generate mnemonics in Japanese, the delimiter is \u3000. But when converting that mnemonic words to entropy or seed, It forget the \u3000 delimiter.

Fix Japanese delimiter bug.
And add Czech and Portuguese wordlist.
Fix Japanese delimiter bug.
And add Czech and Portuguese wordlist.
@prusnak prusnak mentioned this pull request Jun 29, 2023
@prusnak prusnak merged commit 71cf520 into trezor:master Jun 29, 2023
prusnak added a commit that referenced this pull request Aug 13, 2023
@prusnak
Copy link
Member

prusnak commented Aug 13, 2023

I reverted the commit 71cf520 because it failes in the CI.

See https://github.com/trezor/python-mnemonic/actions/runs/5849364691/job/15857611745 as one instance.

@LucienSong please try fixing the issue again, but this time make sure the CI does not fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants