Skip to content
This repository has been archived by the owner on Jun 5, 2019. It is now read-only.

Commit

Permalink
update to protobuf 2.6.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@prusnak
prusnak committed Dec 24, 2015
1 parent 0465db6 commit d2e23a1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

setup(
name='trezor',
version='0.6.8',
version='0.6.9',
author='Bitcoin TREZOR',
author_email='info@bitcointrezor.com',
description='Python library for communicating with TREZOR Bitcoin Hardware Wallet',
Expand All @@ -29,7 +29,7 @@
],
scripts = ['trezorctl'],
test_suite='tests',
install_requires=['ecdsa>=0.9', 'protobuf==2.5.0', 'mnemonic>=0.8', 'hidapi>=0.7.99'],
install_requires=['ecdsa>=0.9', 'protobuf==2.6.1', 'mnemonic>=0.8', 'hidapi>=0.7.99'],

This comment has been minimized.

Sign in to view

Copy link
@romanz

romanz May 4, 2016

Contributor

Is it possible to use 'protobuf>=2.6.1' here?
This would allow using protobuf 3.0.0, in order to add Python 3 support for the TREZOR (issue).

This comment has been minimized.

Sign in to view

Copy link
@prusnak

prusnak May 5, 2016

Author Member

Is protobuf 2.6.1 incompatible with python 3? It's not a good idea to support protobuf 3.x on client where trezor is expecting protobuf 2.6 messages. (I know the wire format is the same, but logic changed and trezor is expecting logic of 2.6 message).

This comment has been minimized.

Sign in to view

Copy link
@romanz

romanz May 5, 2016 •
edited

Contributor

Thanks for the reply!
Unfortunately, protobuf 2.6.1 is indeed incompatible with Python 3 - mainly due to syntax errors:
https://gist.github.com/romanz/f6e9a49218a5726263828715200f8bcb

I tried running python-trezor with protobuf==3.0.0b2.post2 here and trezor-agent seemed to working correctly.

This comment has been minimized.

Sign in to view

Copy link
@prusnak

prusnak May 5, 2016

Author Member

OK, let's do this. Fixed in 7097d1a

This comment has been minimized.

Sign in to view

Copy link
@romanz

romanz May 5, 2016

Contributor

Great :) Thanks a lot!
include_package_data=True,
zip_safe=False,
classifiers=[
Expand Down

0 comments on commit d2e23a1

Please sign in to comment.