This repository has been archived by the owner on May 28, 2019. It is now read-only.
extmod/modtrezorcrypto: return False or None consistently when a signature verification fails #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
real-or-random
force-pushed
the
sig-recovery-return-none
branch
from
3865e10
to
a274a36
Compare
|
rebased on #500 |
|
@real-or-random I guess this one should be switched to regular PR? (After #500 has been merged) |
|
Yes, I had left this as draft because #500 is not merged yet, but this is ready for review! edit: oh it's merged now and now Github complains that this PR needs a rebase... Weird. I'll look into tat |
…ature verification fails So far, we either return False (or None for public recovery) or raise a ValueError (e.g., when the length of the signature). This is inconsistent and dangerous because the inputs to signature verification may be attacker-provided and cannot be assumed to be well-formed. This led to issue trezor#422 where a firmware error is raised when an invalid signature is is provided. This has been fixed for the ethereum app but not for the wallet app. This commit addresses the problem at the core of the issue, i.e., at the verification functions in extmod such that all apps are covered.
real-or-random
force-pushed
the
sig-recovery-return-none
branch
from
a274a36
to
e7e41d1
Compare
|
Okay, sure, there were changes to master of course and I was confused. It's properly rebased now. |
tsusanka
added a commit
to trezor/trezor-firmware
that referenced
this pull request
Apr 17, 2019
|
ACKed by @jpochyla. We're moving to monorepo: https://github.com/trezor/trezor-firmware . I've dared to merge it to master directly, so you don't have to resubmit, I hope that's alright, see trezor/trezor-firmware@5dc0a1e. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we either return False (or None for public recovery) or raise a
ValueError (e.g., when the length of the signature). This is
inconsistent and dangerous because the inputs to signature verification
may be attacker-provided and cannot be assumed to be well-formed.
This led to issue #422 where a firmware error is raised when an invalid
signature is is provided. This has been fixed for the ethereum app but
not for the wallet app. This commit addresses the problem at the core of
the issue, i.e., at the verification functions in extmod such that all
apps are covered.
This is a draft PR because it builds on top of #500. It should not be merged currently. But the only commit is the last one, and this is ready for review.