Commits on Apr 15, 2019

1. extmod/modtrezorcrypto: return False or None consistently when a sign… …

   …ature verification fails
   
   So far, we either return False (or None for public recovery) or raise a
   ValueError (e.g., when the length of the signature). This is
   inconsistent and dangerous because the inputs to signature verification
   may be attacker-provided and cannot be assumed to be well-formed.
   
   This led to issue trezor#422 where a firmware error is raised when an invalid
   signature is is provided. This has been fixed for the ethereum app but
   not for the wallet app. This commit addresses the problem at the core of
   the issue, i.e., at the verification functions in extmod such that all
   apps are covered.

   

   real-or-random committed Apr 15, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for e7e41d1
   • Browse repository at this point

   Copy the full SHA

   e7e41d1 View commit details

   Browse the repository at this point in the history