Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we print coin name during message signing? #1159

Closed
tsusanka opened this issue Aug 3, 2020 · 7 comments · Fixed by #1181
Closed

Do we print coin name during message signing? #1159

tsusanka opened this issue Aug 3, 2020 · 7 comments · Fixed by #1181
Assignees
@mmilata
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Milestone
2020-09

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Aug 3, 2020

We should print the Coin name during message signing so the attacker can not trick the user into signing a message with a different coin than intended.
@tsusanka tsusanka added this to the backlog milestone Aug 3, 2020
@tsusanka
Copy link
Contributor Author

tsusanka commented Aug 3, 2020

@mmilata do you think you could have a look please?

@mmilata mmilata self-assigned this Aug 3, 2020
@mmilata mmilata mentioned this issue Aug 11, 2020
Merged
@tsusanka tsusanka modified the milestones: backlog, 2020-09 Aug 18, 2020
@tsusanka
Copy link
Contributor Author

tsusanka commented Aug 21, 2020 •
edited

@trezor/qa Please test sign and verify functions and make sure it prints the coin's name.

@sorooris
Copy link
Contributor

sorooris commented Aug 24, 2020 •
edited

QA OK
Device: model T 2.3.3 e137f19
Wallet: public ec6b4d
Tested with BTC, LTC and ZEC; device correctly displays the coin's name in the screen header when signing (the single screen) and verifying (both screens).

@bosomt
Copy link

bosomt commented Aug 26, 2020

QA OK

model T revision: df5421e
wallet ec6b4d36cbae2ec1c3f479eb3c1891090790b7c0
tested with BTC,DOGE,ETH,VTC

@sorooris
Copy link
Contributor

QA NOK
Device: model 1 1.9.3 e137f19, df5421e
Wallet: public ec6b4d
Missing coin name in model 1.

image

@tsusanka
Copy link
Contributor Author

tsusanka commented Aug 26, 2020 •
edited

I am suggesting not to deal with that and solve it by Port.

@tsusanka tsusanka added the core Trezor Core firmware. Runs on Trezor Model T and T2B1. label Aug 28, 2020
@bosomt
Copy link

bosomt commented Dec 21, 2020

QA OK

model One is missing Coin information as expected #1159 (comment)

Nixos
wallet.trezor.io be4e63a6db60aaa07ae982fd77262c59a686ad88
Device: fw-regular-2.3.5-889a3699 + trezor-fw-regular-1.9.4-889a3699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmilata mmilata

Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
None yet
Milestone
2020-09
Development

Successfully merging a pull request may close this issue.

core: display coin name when signing message trezor/trezor-firmware
4 participants
@mmilata @tsusanka @sorooris @bosomt