Update QR-code-generator

[matejcik]

https://github.com/nayuki/QR-Code-generator

couldn't find a changelog, reviewing all commits shouldn't be too difficult though

I also notice they have a Rust version! and it's available as a crate too. Maybe investigate switching to that?

[nayuki]

I see that the current version of this Trezor repository has pinned my QR lib at a version from 2019-02-14.

Trezor is using the C language version of my library. What has changed between then and now in the C port:

• Slightly different algorithm for detecting finder patterns for penalty calculation.
• Improved the correctness of handling integers - types, bit widths, signedness, arithmetic, etc.
• Revamp some private/internal functions and variables.

For the C lib, when moving from the 2019-02-14 version to the 2020-09-12 version, the impact on callers should be small.

[nayuki]

My C library completely avoids heap allocations; it expects the caller to pass in input/output buffers and scratch space. This is not true for my other language ports; all of them do heap allocations and deallocations. So neither my C++ lib nor Rust lib match this feature of my C lib. Also, my Rust lib doesn't define a C foreign function interface (FFI) or do anything to help users coming from other languages.

[prusnak]

@nayuki Thanks for the summary! It seems like it makes sense to stick to the C version for now.

Maybe in the future when we rewrite the whole rendering stack to Rust (so no FFI is needed) and when qrcodegen crate works with #![no_std] option and has no allocations, it would make sense to switch.

[bosomt]

@mmilata any special testing needed on our side or just test/validate/compare QR code generated by T1 and TT in current dev master ?

[nayuki]

Maybe in the future [...] when qrcodegen crate works with #![no_std] option and has no allocations

FYI I made this a reality last week: https://github.com/nayuki/QR-Code-generator/tree/master/rust-no-heap

[mmilata]

@bosomt generating and validating a QR code on T1 and TT should be enough

@nayuki neat! we might switch to that eventually

[bosomt]

QA OK trezor-fw-regular-2.4.3-221977ad.bin
QA OK trezor-fw-regular-1.10.4-221977ad.bin

BTC receive QR code OK