Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EIP-1559 in legacy #1834

Closed
tsusanka opened this issue Oct 6, 2021 · 3 comments · Fixed by #1861
Closed

Support EIP-1559 in legacy #1834

tsusanka opened this issue Oct 6, 2021 · 3 comments · Fixed by #1861
Assignees
@mmilata
Labels
feature Product related issue visible for end user T1B1 legacy Trezor One

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Oct 6, 2021

It seems MetaMask is using EIP-1559 for ETH transactions which are not supported by legacy at this moment, which makes T1 unusable with MetaMask. @matejcik before we decide if we want this could you or someone from the team please guesstimate how many mandays this would take?
This was referenced Oct 6, 2021
Closed
Open
@matejcik
Copy link
Contributor

matejcik commented Oct 6, 2021

I estimate 3 MDs, and I believe we already have this in the pipeline for when Suite EIP1559 support is imminent. We can of course implement it earlier.

@prusnak
Copy link
Member

prusnak commented Oct 6, 2021 •
edited
Loading

We should implement it earlier than Suite. Some 3rd party ETH wallets switched to using EIP-1559 exclusively, so Trezor Model One cannot be used anymore with these.

@trezor trezor locked as too heated and limited conversation to collaborators Oct 6, 2021
@tsusanka tsusanka assigned mmilata and unassigned matejcik Oct 7, 2021
@tsusanka tsusanka removed the feature label Oct 7, 2021
@tsusanka tsusanka added the feature Product related issue visible for end user label Oct 7, 2021
@bosomt
Copy link

bosomt commented Nov 17, 2021

QA OK
#1861 (comment)

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mmilata mmilata

Labels
feature Product related issue visible for end user T1B1 legacy Trezor One
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ethereum EIP-1559 transaction support in legacy trezor/trezor-firmware
5 participants
@prusnak @mmilata @matejcik @tsusanka @bosomt