Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): introduce and enforce limit on label length (fixes #1399) #1403

Merged
merged 1 commit into from
Jan 12, 2021
Merged

feat(core): introduce and enforce limit on label length (fixes #1399) #1403

merged 1 commit into from
Jan 12, 2021

Conversation

matejcik
Copy link
Contributor

@matejcik matejcik commented Jan 4, 2021

No description provided.

@matejcik matejcik requested review from mmilata and removed request for andrewkozlik January 4, 2021 11:48
mmilata
mmilata approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did'nt manage to trigger any bad behavior when upgrading device with longer label in storage. "W" * 32 still overflows but not sure whether checking the actual pixel-width of the label makes sense here.

@matejcik
Copy link
Contributor Author

waiting for #1384 so that I can cleanly merge the changelog entry

@matejcik matejcik merged commit fc4e15f into master Jan 12, 2021
@matejcik matejcik deleted the matejcik/label-too-long branch January 12, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@tsusanka tsusanka Awaiting requested review from tsusanka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matejcik @mmilata