Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/ui: Improve semantics of layout functions #1731

Merged
merged 9 commits into from Jul 26, 2021
Merged

core/ui: Improve semantics of layout functions #1731

merged 9 commits into from Jul 26, 2021

Commits on Jul 26, 2021

  1. refactor(core/ui): reorganize line width constants

    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    b79a50a View commit details
    Browse the repository at this point in the history

  2. refactor(core/ui): replace confirm_hex, clarify API 

    Truncation options were removed.

Subtitle distinct from description was removed.

confirm_hex was replaced by confirm_blob. You should use confirm_blob
when displaying data that is not human readable and can be broken at any
character.

Also it is now possible to pass bytes, which are automatically converted
to hex.

For displaying addresses, a separate confirm_address is introduced,
which simply delegates to confirm_blob, but has a more limited
signature.

Analogously, there is confirm_text for text data (should maybe be used
in many places where we currently use confirm_metadata) and a
specialized confirm_amount.
    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    bee3b82 View commit details
    Browse the repository at this point in the history

  3. refactor(core): use confirm_blob instead of confirm_hex in apps

    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    fbdfabc View commit details
    Browse the repository at this point in the history

  4. fix(core/stellar): fail cleanly when asset code has wrong length

    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    38b7b3b View commit details
    Browse the repository at this point in the history

  5. fix(tests/ui_tests): if a UI test result changed, show it as new

    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    a42be68 View commit details
    Browse the repository at this point in the history

  6. refactor(core/stellar): use semantically appropriate layouts everywhere

    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    b91fd72 View commit details
    Browse the repository at this point in the history

  7. fix(core/bitcoin): nicer UI for ownership proofs

    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    949a545 View commit details
    Browse the repository at this point in the history

  8. chore(core/ui): drop no longer used confirm_proposals_tezos

    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    18a4b95 View commit details
    Browse the repository at this point in the history

  9. chore(tests): regenerate UI test fixtures

    @matejcik
    matejcik committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    2d10eb6 View commit details
    Browse the repository at this point in the history