core/ui: Improve semantics of layout functions #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
force-pushed
the
matejcik/confirm-hex
branch
from
d8c556e
to
4bcab90
Compare
There was a problem hiding this comment.
@andrewkozlik please take a look at 9de567b and the resulting UI diff of
get_ownership_proof
9de567b LGTM. I haven't looked at the rest.
mmilata
approved these changes
Jul 23, 2021
Truncation options were removed. Subtitle distinct from description was removed. confirm_hex was replaced by confirm_blob. You should use confirm_blob when displaying data that is not human readable and can be broken at any character. Also it is now possible to pass bytes, which are automatically converted to hex. For displaying addresses, a separate confirm_address is introduced, which simply delegates to confirm_blob, but has a more limited signature. Analogously, there is confirm_text for text data (should maybe be used in many places where we currently use confirm_metadata) and a specialized confirm_amount.
matejcik
force-pushed
the
matejcik/confirm-hex
branch
from
b1b284b
to
2d10eb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
confirm_hexwas replaced by a more appropriateconfirm_blob.There are now two main "confirm property" functions:
confirm_blobshould be used when the property is not human-readable text. So for public keys, hashes, passphrase, etc.confirm_textshould be used when the property is human-readable text. So flag names, message texts, etc.Two specializations exist for common cases:
confirm_addressandconfirm_amount.All screens using the new functions are auto-paginated. This produces part of the UI diff.
The other part is using semantically appropriate layouts from the above set in altcoins, which in some cases changes rendering from bold font to monospace font.
A very significant part of the PR is complete overhaul of Stellar UI.
@andrewkozlik please take a look at 9de567b and the resulting UI diff of
get_ownership_proof