Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signed Ethereum network and token definitions from host #2410

Merged
merged 19 commits into from
Mar 24, 2023
Merged

Signed Ethereum network and token definitions from host #2410

merged 19 commits into from
Mar 24, 2023

Commits on Mar 24, 2023

  1. refactor(core): delegate EthereumGetPublicKey to bitcoin GetPublicKey

    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    4994ae3 View commit details
    Browse the repository at this point in the history

  2. docs(common): how to add new protobuf message

    @matejcik
    Martin Novák authored and matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ab6cf72 View commit details
    Browse the repository at this point in the history

  3. feat(common): protobuf messages for Ethereum definitions

    @matejcik
    Martin Novák authored and matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ee72762 View commit details
    Browse the repository at this point in the history

  4. docs: document Ethereum definition binary format

    @matejcik
    Martin Novák authored and matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    2d1d4f4 View commit details
    Browse the repository at this point in the history

  5. feat(common): switch to external Ethereum definitions, add generators

    @matejcik
    Martin Novák authored and matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    d09e0ad View commit details
    Browse the repository at this point in the history

  6. fix(common): deal with duplicity code leftovers 

    also fixes #2759
    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    40e3283 View commit details
    Browse the repository at this point in the history

  7. feat(core): external Ethereum definitions

    @matejcik
    Martin Novák authored and matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    7028552 View commit details
    Browse the repository at this point in the history

  8. feat(legacy): support external Ethereum definitions

    @matejcik
    Martin Novák authored and matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    4571c2e View commit details
    Browse the repository at this point in the history

  9. feat(python): support external Ethereum definitions

    @matejcik
    Martin Novák authored and matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    202cf0c View commit details
    Browse the repository at this point in the history

  10. feat(core): implement CoSi module and CoSi verification

    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    0ae454b View commit details
    Browse the repository at this point in the history

  11. feat(core): update Ethereum definitions to verify using CoSi

    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e35b005 View commit details
    Browse the repository at this point in the history

  12. feat(legacy): implement CoSi verification

    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    105bace View commit details
    Browse the repository at this point in the history

  13. feat(legacy): update Ethereum definitions to verify using CoSi

    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    9ea9cb5 View commit details
    Browse the repository at this point in the history

  14. tests: update device_tests for external definitions

    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    2d0c4e8 View commit details
    Browse the repository at this point in the history

  15. fix(python/trezorctl): fix colliding option shortcut in ethereum sign-tx 

    fixes #2535
    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8c77bd4 View commit details
    Browse the repository at this point in the history

  16. fix(legacy): display very large amounts 

    Previously, an amount whose decimal representation with suffix does not
fit in buffer would not be rendered at all. This looks weird in
"Send                          to address 0xblabla".

Enlarging the buffer lets the amount be stringified. Then it won't fit
on screen so this is not a perfect fix, but "Send 25000000... to
address" is better than before.
    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    7fc4cf5 View commit details
    Browse the repository at this point in the history

  17. fix(tests): only override left clicks in index custom script

    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    b05115c View commit details
    Browse the repository at this point in the history

  18. fix(legacy): limit EthereumGetPublicKey allowable paths

    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ccd4bf6 View commit details
    Browse the repository at this point in the history

  19. fix(core): remove shutdown() 

    In a very weird situation, our declaration of `shutdown()` shadows a
function `shutdown(int, int)` from sys/socket, which _just happens_ to
be called by libxcb when closing the sdl window. This calls
`main_clean_exit` which calls into micropython and causes at best an
uncaught NLR and at worst an outright segfault because by that time the
micropython environment doesn't exist anymore.

I didn't think this sort of thing would be possible but here we are??

Fixed by removing `__shutdown()` and replacing `shutdown` with
`trezor_shutdown`
    @matejcik
    matejcik committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    5300790 View commit details
    Browse the repository at this point in the history