Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defintions of ethereum testnets #2759

Closed
mmilata opened this issue Jan 19, 2023 · 2 comments
Closed

Fix defintions of ethereum testnets #2759

mmilata opened this issue Jan 19, 2023 · 2 comments
Assignees
@matejcik
Labels
bug Something isn't working as expected
Milestone
🐙 FW release

Comments

@mmilata
Copy link
Member

mmilata commented Jan 19, 2023

trezor/trezor-suite#7262 (comment)
@mmilata mmilata added the bug Something isn't working as expected label Jan 19, 2023
@mmilata mmilata self-assigned this Jan 19, 2023
@mmilata mmilata added this to the 🐙 FW release milestone Jan 19, 2023
matejcik added a commit that referenced this issue Feb 10, 2023
@matejcik
fix(common): deal with duplicity code leftovers
45b949b 
also fixes #2759
matejcik added a commit that referenced this issue Feb 14, 2023
@matejcik
fix(common): deal with duplicity code leftovers
4d30886 
also fixes #2759
@Hannsek Hannsek assigned matejcik and unassigned mmilata Feb 16, 2023
@mmilata
Copy link
Member Author

mmilata commented Mar 2, 2023

The symbol was changed to tETH for official testnets in #2852 (see also 9b97206).

Eventually #2410 will be the ultimate solution.

@STew790
Copy link

STew790 commented Mar 6, 2023

QA OK
Changed to tETH and correctly shows it.

Info:

  • Suite version: desktop 23.4.0 (f4dee18ecd17bcce530ae7837c5a34a7b922762a)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/23.4.0 Chrome/104.0.5112.124 Electron/20.3.12 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model 1 1.12.2 Universal (revision e2416bc)
  • Transport: BridgeTransport 2.0.32

matejcik added a commit that referenced this issue Mar 20, 2023
@matejcik
fix(common): deal with duplicity code leftovers
2ec6f36 
also fixes #2759
matejcik added a commit that referenced this issue Mar 24, 2023
@matejcik
fix(common): deal with duplicity code leftovers
40e3283 
also fixes #2759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejcik matejcik

Labels
bug Something isn't working as expected
Projects
Firmware
Archived in project
Milestone
🐙 FW release
Development

No branches or pull requests
3 participants
@mmilata @matejcik @STew790