feat(core): Start displaying Ethereum ABI in a generalized way #3174
+445
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step toward solving issue trezor#69 Improved Ethereum address display and changed test cases to use addresses including letter to see the upper/lower case formatting. Added test for known ERC-20 token (DAI) [no changelog]
More thorough handling of transaction properties (value vs data length). Restore special handling of ERC-20 token transfers (a bit ugly right now, see comment about `Any` at the top of _fetch_abi_input_properties.
Instead break _fetch_abi_input_properties in two, one handling transfers, and also break out an inner generator function for iterating over the input parameter definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step towards #69