Recovery go to previous word

[grdddj]

Fixes #286:

• allowing to go back to previous word in recovery process

I am creating a bunch of click tests to try all the possible scenarios

[mmilata]

Looking good.

Are you planning to add more tests as part of this PR?

I noticed that in model T you can go and change any previous word, but on TS3 you can only go to the last one, is that intentional?

[Hannsek]

I can change any previous word on TS3.

If someone press previous, it goes to the screen where there is delete button and the word:

Instead, can it be the screen with multiple options?

This is because if I go back, I have to delete at least 2 letters every time I want to change something

On TT, instead this screen

go to this

(Instead

go to
)

In general, go to screen that has multiple options without deleting single letter.

Ideally, if this screen suggests the same word. See the word machine, there it is right. But instead of bind you can see the suggested bicycle, that's not right.

[grdddj]

I can change any previous word on TS3.

If someone press previous, it goes to the screen where there is delete button and the word:

Instead, can it be the screen with multiple options? This is because if I go back, I have to delete at least 2 letters every time I want to change something

On TT, instead this screen go to this

(Instead go to )

In general, go to screen that has multiple options without deleting single letter.

Ideally, if this screen suggests the same word. See the word machine, there it is right. But instead of bind you can see the suggested bicycle, that's not right.

These things are technically possible, but certainly not easily/cleanly. I would vote for simplicity --- the cost of users having to click delete a couple of times is minimal, considering how very few users will ever encounter this situation.

[grdddj]

Are you planning to add more tests as part of this PR?

Yes, I will add more tests, once we finalize the wanted requirements.

[grdddj]

These things are technically possible, but certainly not easily/cleanly. I would vote for simplicity --- the cost of users having to click delete a couple of times is minimal, considering how very few users will ever encounter this situation.

@Hannsek Want to ask about the current status - are you OK with this, or do you want to do the changes above? I would estimate it at couple hours to 1 day of work.

If we are OK with the current state, I will do some more tests to freeze the functionality and then we are ready to merge.

[Hannsek]

Im ok with this for now.
But please change the word delete to previous on TS3 when no letter is input, if not yet changed.

[Hannsek]

@grdddj What is missing here?

[grdddj]

@grdddj What is missing here?

I think that nothing really important. The tests I wanted to add do not have a big priority

[Hannsek]

So we can merge it?

[github-actions]

legacy UI changes	device test(screens) main(screens)

[github-actions]

core UI changes	device test	click test	persistence test
Model T	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
Model Safe 3	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
All	main(screens)

[grdddj]

So we can merge it?

I guess so, after the CI will be green and the PR is approved

[mmilata]

I think it's ready but some tests are failing. Also please remove the TODO lines and/or turn them into GH issue.

[grdddj]

I think it's ready but some tests are failing. Also please remove the TODO lines and/or turn them into GH issue.

Right, sorry about that. Should be rebased and green now, TODOs deleted

[grdddj]

CI is green, ready to merge @mmilata

[bosomt]

Testing on dry run.
Previous button is available even before i enter first word /nothing happens when pressed/
Is that expected ?

Info:

• Suite version: desktop 24.2.2 (6544eb4cdb6f8982f3f391307e2bff5784db2bcf)
• Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.2.2 Chrome/118.0.5993.129 Electron/27.0.4 Safari/537.36
• OS: MacIntel
• Screen: 1512x982
• Device: Trezor T2B1 2.6.5 regular (revision e1f696b)
• Transport: BridgeTransport 2.0.33

[Hannsek]

It is not. Good catch. @grdddj

[grdddj]

It is not. Good catch. @grdddj

That is OK in my perspective, if the button does nothing. Yeah, it would be clearer when not showing it at all, but at the cost of more code.

How do we want it to look/behave like?

[Hannsek]

Ideally, it should not be there if no word is present. I'll create an issue.

[bosomt]

QA OK

tested dry run on firmware-T2T1-2.6.5-561a697
tested recovery on firmware-T2T1-2.6.5-561a697
tested dry run on firmware-T2B1-2.6.5-561a697
tested recovery on firmware-T2B1-2.6.5-561a697