-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic trezor support for Verge (XVG) #816
Conversation
Is this issue already fixed? vergecurrency/electrum#12 |
@prusnak It has been fixed with vergecurrency/electrum#13 and this PR. Closed the ticket and attached the tickets for its fix. I've also locally tested receiving and sending XVG via a trezor emulator, so this shouldn't be a problem anymore. |
…is actually locked.
Hi there, thank you for your PR. After a thorough discussion in our Product team, we have decided we do not wish to include this PR in our firmware. Due to our limited capacity, we need to restrict our support to coins that we can afford to maintain in the long run. We hope you’ll understand this decision. |
Hi, I'm completely unable to understand your decision. It's 66 lines of code that have been changed overall with the addition of a +4kb PNG. What do you mean by having a "limited capacity"? I think this is the vaguest answer that I've ever got. I'm totally disappointed to get such an answer after 6 months of waiting. |
why would this not be easy to maintain in the longrun? @tsusanka and what kind of firmware storage space does the device have? |
Apologies, we have accidentally included this into a group of PRs which make substantial changes in the code. I have overlooked this changes only |
…are into verge-trezor-support
Add basic wallet support for trezor via the electrum wallet supplied by Verge.
This PR is connected to the initial build of our electrum wallet see: vergecurrency/electrum#13
I've tested most stuff manually via the emulator.