Skip to content
This repository has been archived by the owner on Apr 16, 2019. It is now read-only.

Bech32 p2wsh addresses don't fit on display #289

Closed
karelbilek opened this issue Jan 15, 2018 · 2 comments
Closed

Bech32 p2wsh addresses don't fit on display #289

karelbilek opened this issue Jan 15, 2018 · 2 comments

Comments

@karelbilek
Copy link
Contributor

Bech32 pwsh addresses currently don't fit on display in most cases.

In examples I tried, it came 2 or 3 letters short.

Examples for example in BIP173 itself

The problem will maybe be worse in the new bcash address format, if we will implement it
@prusnak
Copy link
Member

prusnak commented Jan 15, 2018

Please test

@karelbilek
Copy link
Contributor Author

karelbilek commented Jan 15, 2018 •
edited
Loading

Nope, this makes the last line fit, but I realized even the previous lines don't fit, since they are longer than the display. (I can't make picture because my phone cam is broken :( )

@karelbilek karelbilek mentioned this issue Jan 15, 2018
Closed
@karelbilek karelbilek mentioned this issue Feb 27, 2018
Closed
zulucrypto pushed a commit to zulucrypto/trezor-mcu that referenced this issue Mar 19, 2018
@prusnak @zulucrypto
rework ConfirmOutput layout (fixes trezor#289)
ba1c1da
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pack layout if lines too long
2 participants
@prusnak @karelbilek