Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema/validations followup 2 #10474

Open
mroz22 opened this issue Jan 3, 2024 · 0 comments
Open

schema/validations followup 2 #10474

mroz22 opened this issue Jan 3, 2024 · 0 comments
Labels
code Code improvements

Comments

@mroz22
Copy link
Contributor

mroz22 commented Jan 3, 2024

followup for #10280 where we interwined api definition with runtime params validations. it uncovered couple of places where types did not match runtime.

so far we only decided to adjust types to match bugged runtime because fixing runtime could in fact be breaking for some implementations that rely on this behaviour. we should definitely fix it either in the next major version (10) or maybe we decide to introduce a breaking change fix already into version 10

@mroz22 mroz22 added the code Code improvements label Jan 3, 2024
martykan added a commit to martykan/trezor-suite that referenced this issue Jan 3, 2024
martykan added a commit to martykan/trezor-suite that referenced this issue Jan 5, 2024
martykan added a commit to martykan/trezor-suite that referenced this issue Jan 5, 2024
martykan added a commit to martykan/trezor-suite that referenced this issue Jan 5, 2024
fix(connect): unit test related to loosened `TxOutputType`, notes about issue trezor#10474
martykan added a commit to martykan/trezor-suite that referenced this issue Jan 5, 2024
fix(connect): unit test related to loosened `TxOutputType`, notes about issue trezor#10474
martykan added a commit to martykan/trezor-suite that referenced this issue Jan 5, 2024
fix(connect): unit test related to loosened `TxOutputType`, notes about issue trezor#10474
mroz22 pushed a commit that referenced this issue Jan 5, 2024
fix(connect): unit test related to loosened `TxOutputType`, notes about issue #10474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements
Projects
Status: No status
Development

No branches or pull requests

1 participant