Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not register into round if too many utxos are banned #8394

Closed
hynek-jina opened this issue May 5, 2023 · 3 comments · Fixed by #8484
Closed

Do not register into round if too many utxos are banned #8394

hynek-jina opened this issue May 5, 2023 · 3 comments · Fixed by #8484
Assignees
Labels
coinjoin Related to coinjoin feature

Comments

@hynek-jina
Copy link
Contributor

hynek-jina commented May 5, 2023

If a user has banned more than 40% of total non-private utxos or sum of banned utxos amounts is greater than 40% then they should not register to the next round for a certain period of time (1 hour).

It could work as a prevention of unknown bugs like #8307

@hynek-jina hynek-jina added the coinjoin Related to coinjoin feature label May 5, 2023
@matejkriz
Copy link
Member

fixed by #8484 ?

@bosomt
Copy link
Contributor

bosomt commented May 30, 2023

AFAIK there is no way to test it on our side right ?

@matejkriz
Copy link
Member

You can test it, at least on testnet where it's more OK to ruin the round to have banned UTXO, but I believe it's ok to test it during normal coinjoin testing...

@hynek-jina hynek-jina added this to the 🍜 Coinjoin - 2nd phase milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coinjoin Related to coinjoin feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants