Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputBanned for no apparent reason #8307

Open
nostitos opened this issue Apr 30, 2023 · 12 comments
Open

InputBanned for no apparent reason #8307

nostitos opened this issue Apr 30, 2023 · 12 comments
Labels
bug Something isn't working as expected coinjoin Related to coinjoin feature

Comments

@nostitos
Copy link

My PC is always on and internet extremely stable. I can't think of any reason why my input would be banned.

That explain why of the many many input none of them get registered into a CJ for days.

I can't see anything in the logs that would explain why my inputs would have gotten banned.

I think we need comprehensive logs of the process in the main UI that would show the outcome of a mix attempt and when inputs are banned.

@nostitos nostitos added the bug Something isn't working as expected label Apr 30, 2023
@hynek-jina
Copy link
Contributor

It is hard to replicate this issue.
There are many reason for which you could ruin the round. For example your connection might be strong but the tor is probably not under your control.
These banned inputs should be accepted again in few days..

@hynek-jina hynek-jina closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2023
@nostitos
Copy link
Author

We're talking about 8 pages times 25 UTXO per page worth of banned coins.

Looks like something is off about Suite and not just Tor stability.

I see my Trezor signing CJ transactoin then nothing, not even some fail message. It keeps looping like this over all steps, It's frustrating to get so little result and no feedback.

@hynek-jina
Copy link
Contributor

I assume that you have received one utxo and they were splited during the coinjoin, right? How many utxos do you have now? (8*25 → 200 sounds like too many.. so can you please confirm?)

@nostitos
Copy link
Author

nostitos commented May 1, 2023

pretty much, last page has just 1 so 176 UTXO

A whole lot of my sufficiently mixed coin (target 5) are 2-20$ Disgustingly small compared to how much was sent to be mixed.

@hynek-jina
Copy link
Contributor

I'm sorry for that.. this is very annoying.. it seems to me like this issue:
zkSNACKs/WalletWasabi#10462

You privacy is probably very good already.. however wabisabi client library thinks otherwise...
We are investigating that.. but so far without significant improvement.. 😞

@nostitos
Copy link
Author

nostitos commented May 1, 2023

image

Half of my coins are almost dusts.

I don't think privacy assumption can be made about my larger coins, I can see the last CJ I participated in being mostly breaking small UTXO smaller.

One problem is that my private coins have 10 to 16 anon score. While my target is 5.

I think these small coins and these already private coins were selected because the bigger ones got banned.

@nopara73
Copy link

nopara73 commented May 2, 2023

Something seems very off. The number of coins are governed by the coin selection and amount decomposition algorithms. We have not encountered this before, which is strange. Do I recall correctly that you guys are using the Wasabi code directly for that? Is it possible that you made some modifications?

@nopara73
Copy link

nopara73 commented May 2, 2023

One problem is that my private coins have 10 to 16 anon score. While my target is 5.

That's normal. If there's 10 to 16 equal outputs to your coin, then you'll gain that anonscore.

@nopara73
Copy link

nopara73 commented May 2, 2023

I think these small coins and these already private coins were selected because the bigger ones got banned.

I think this is causing the UTXO inflation! Assume coins get banned very often, but not always. In that case there'll always be fewer coins selected than outputs created.

@nopara73
Copy link

nopara73 commented May 2, 2023

Thus, the following actions can be taken:

  1. Solution: Make sure coins don't get banned, there must be a lot of Tor reliability issues you have right now. Remember why I was so worried about an independent Tor implementation back then? You'll now need to make your Tor implementation battle tested.
  2. Fallback: Regulate the coinjoining pace by assessing the quantities of short banned and non-banned coins and performing coinjoins only when their numbers look good (this might, in some extreme situations, hinder coinjoining altogether? But it is preferable to UTXO inflation, I suppose?)

@onvej-sl
Copy link

onvej-sl commented May 2, 2023

Something seems very off. The number of coins are governed by the coin selection and amount decomposition algorithms. We have not encountered this before, which is strange. Do I recall correctly that you guys are using the Wasabi code directly for that? Is it possible that you made some modifications?

As far as I can remember, this is the only modification that could be related: zkSNACKs/WalletWasabi#10096.

@hynek-jina hynek-jina reopened this May 2, 2023
@hynek-jina hynek-jina added the coinjoin Related to coinjoin feature label May 2, 2023
@nopara73
Copy link

nopara73 commented May 3, 2023

@turbolay commented on slack that that PR can lead to coin inflation, which would be good news for you, because rolling that back would be much easier than stabilizing Tor implementation. I am not convinced that is the culprit, but certainly worth an investigation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected coinjoin Related to coinjoin feature
Projects
Status: No status
Development

No branches or pull requests

5 participants