Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite-native) Device switcher improvements #12523

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vytick
Copy link
Contributor

@vytick vytick commented May 22, 2024

  • add fiat rates for each wallet

Related Issue

Part of #12421

Screenshots:

@vytick vytick added the mobile Suite Lite issues and PRs label May 22, 2024
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Filesystem access npm/fs-constants@1.0.0
Filesystem access npm/detect-libc@1.0.3
Shell access npm/detect-libc@1.0.3
Network access npm/simple-get@2.8.2
Network access npm/simple-get@2.8.2
Filesystem access npm/mkdirp-classic@0.5.3
New author npm/use-sync-external-store@1.2.0
Filesystem access npm/shiki@0.14.7
Network access npm/shiki@0.14.7

View full report↗︎

Next steps

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/fs-constants@1.0.0
  • @SocketSecurity ignore npm/detect-libc@1.0.3
  • @SocketSecurity ignore npm/simple-get@2.8.2
  • @SocketSecurity ignore npm/mkdirp-classic@0.5.3
  • @SocketSecurity ignore npm/use-sync-external-store@1.2.0
  • @SocketSecurity ignore npm/shiki@0.14.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant