Refactor/notifications #4589
Merged
Refactor/notifications #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
marekrjpolak
force-pushed
the
refactor/notifications
branch
2 times, most recently
from
94dac31
to
97379b5
Compare
marekrjpolak
force-pushed
the
refactor/notifications
branch
from
97379b5
to
c22e728
Compare
marekrjpolak
force-pushed
the
refactor/notifications
branch
from
c22e728
to
04c251d
Compare
marekrjpolak
requested review from
matejkriz,
mroz22 and
tomasklim
as code owners
tomasklim
added
the
READY FOR REVIEW
tomasklim
requested changes
Jan 12, 2022
packages/suite/src/components/suite/NotificationRenderer/index.tsx
Outdated
Show resolved
Hide resolved
packages/suite/src/components/suite/NotificationRenderer/renderers/UriSchemeRenderers.tsx
Outdated
Show resolved
Hide resolved
packages/suite/src/components/suite/NotificationRenderer/renderers/UriSchemeRenderers.tsx
Outdated
Show resolved
Hide resolved
tomasklim
approved these changes
Jan 14, 2022
|
Please squash it @marekrjpolak |
marekrjpolak
force-pushed
the
refactor/notifications
branch
from
6d04f66
to
736cf5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bigger refactoring of notifications, mostly replacing HOCs with renderer components. Now should be easier to implement more complex notifications, read redux data from them etc.