Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect-web): fix imports from connect #8508

Merged
merged 2 commits into from
May 19, 2023
Merged

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented May 18, 2023

this should fix the problem reported #8506

fix(connect-web): fix imports from connect shoudl remove all imports from connect-web package that caused importing from connect core
ci(connect): add inline-script size check adds some not very clever check that could prevent accidental bundling of stuff in the future

@mroz22 mroz22 marked this pull request as ready for review May 19, 2023 08:23
Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe.

@mroz22 mroz22 merged commit 1804469 into develop May 19, 2023
32 checks passed
@mroz22 mroz22 deleted the fix-connect-exports branch May 19, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants