Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derivation path added in account details #9719

Merged
merged 2 commits into from Nov 13, 2023
Merged

Derivation path added in account details #9719

merged 2 commits into from Nov 13, 2023

Conversation

hynek-jina
Copy link
Contributor

@hynek-jina hynek-jina commented Oct 23, 2023 •
edited

Resolves: #6781

  • Add Derivation path field between Account type and Public key (XPUB) fields.

Was already done:

  • Change the Account tab to Details tab

Missing part:

  • Where Account tab is not present, create one. (e.g. ETH account)
    → Not requested anymore

tomasklim
tomasklim reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@tomasklim tomasklim left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For Details tab go to AccountsNavigation.tsx and change line 49 to false. Probably you also need to show XPUB only for bitcoin-like, cardano coins?

@hynek-jina
Copy link
Contributor Author

@Hermez-cz
Do you want to make a Details tab for ETH and Cardano too? And if so, do you want to have there Account type section or only this Derivation path? 🙏

@Hermez-cz
Copy link

@Hermez-cz Do you want to make a Details tab for ETH and Cardano too? And if so, do you want to have there Account type section or only this Derivation path? 🙏

Not for now, thanks. Let's have it only for the BTC-like accounts now please.

@matejkriz matejkriz assigned hynek-jina and tomasklim and unassigned hynek-jina Nov 10, 2023
@tomasklim tomasklim merged commit a36a9c4 into develop Nov 13, 2023
32 of 33 checks passed
@tomasklim tomasklim deleted the feat/derivation_path branch November 13, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasklim tomasklim tomasklim approved these changes

@alex-jerechinsky alex-jerechinsky Awaiting requested review from alex-jerechinsky

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

@matejkriz matejkriz Awaiting requested review from matejkriz

Assignees

@tomasklim tomasklim

Labels
None yet
Projects
No open projects
Suite Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display derivation path
3 participants
@hynek-jina @Hermez-cz @tomasklim