Fix libusb and build release failed #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem! Thanks for reviewing! |
Closed
This was referenced Jan 6, 2024
6 tasks
|
Would love a release for this PR, thanks @nekoteoj for the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #297
Solution:
libusb.go. Golang 1.21 doesn't allow defining a method for non-local structs. The solution here is to create a type alias for used C interop structs. Then, we can define methods for these type aliases. For example, an alias forC.struct_libusb_endpoint_descriptorcan be defined withtype Struct_Libusb_Endpoint_Descriptor = C.struct_libusb_endpoint_descriptor.apple-codesignneed a newer version of cargo in the packaging Docker image. To resolve this, I update the Fedora version in the packaging Dockerfile to version 39.I tested this using my Trezor model one is it's working great. Also, I tested the build release command and everything work fine now too.