Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete file migrations. #8

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Delete file migrations. #8

merged 1 commit into from
Oct 19, 2018

Conversation

triadev
Copy link
Owner

@triadev triadev commented Oct 18, 2018

No description provided.

@triadev triadev force-pushed the refactoring branch 3 times, most recently from cb9723b to f80b1ea Compare October 18, 2018 15:50
@codecov-io
Copy link

codecov-io commented Oct 18, 2018

Codecov Report

Merging #8 into master will decrease coverage by 12.39%.
The diff coverage is 81.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
- Coverage     94.35%   81.96%   -12.4%     
+ Complexity      234      145      -89     
============================================
  Files            39       27      -12     
  Lines           762      377     -385     
============================================
- Hits            719      309     -410     
- Misses           43       68      +25
Impacted Files Coverage Δ Complexity Δ
...Provider/ElasticsearchMigrationServiceProvider.php 100% <ø> (ø) 2 <0> (-1) ⬇️
src/Business/Migration/DeleteByQuery.php 0% <0%> (-100%) 4 <4> (+2)
src/Business/Migration/UpdateByQuery.php 0% <0%> (-100%) 4 <4> (+1)
...Business/Repository/ElasticsearchMigrationStep.php 94.44% <100%> (-1.02%) 12 <0> (-2)
src/Business/Migration/UpdateIndexMapping.php 100% <100%> (ø) 5 <5> (?)
src/Business/Repository/ElasticsearchMigration.php 100% <100%> (ø) 14 <0> (-2) ⬇️
src/Business/Repository/ElasticsearchClients.php 100% <100%> (ø) 7 <7> (?)
src/Business/Migration/Reindex.php 100% <100%> (ø) 5 <5> (+2) ⬆️
src/Business/Migration/AbstractMigration.php 100% <100%> (ø) 2 <2> (?)
...0000_create_elasticsearch_migration_step_table.php 83.33% <100%> (ø) 2 <0> (ø) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 458c27b...2faa025. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 18, 2018

Pull Request Test Coverage Report for Build 181

  • 182 of 225 (80.89%) changed or added relevant lines in 18 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-11.4%) to 83.483%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Business/Migration/CreateIndex.php 9 10 90.0%
src/Business/Migration/DeleteIndex.php 9 10 90.0%
src/Business/Migration/PutAlias.php 11 12 91.67%
src/Business/Migration/DeleteAlias.php 10 12 83.33%
src/Business/Migration/DeleteByQuery.php 0 3 0.0%
src/Business/Migration/UpdateByQuery.php 0 3 0.0%
src/ElasticsearchMigration.php 36 47 76.6%
src/Business/Mapper/MigrationTypes.php 21 42 50.0%
Files with Coverage Reduction New Missed Lines %
src/ElasticsearchMigration.php 1 77.36%
src/Business/Migration/UpdateByQuery.php 2 0.0%
src/Business/Migration/DeleteByQuery.php 2 0.0%
Totals Coverage Status
Change from base Build 148: -11.4%
Covered Lines: 278
Relevant Lines: 333

💛 - Coveralls

@triadev triadev merged commit 2416040 into master Oct 19, 2018
@triadev triadev deleted the refactoring branch October 21, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants