Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setnull as deletion method for default searchurls. #2640

Merged
merged 1 commit into from Jul 18, 2020
Merged

Document setnull as deletion method for default searchurls. #2640

merged 1 commit into from Jul 18, 2020

Conversation

dllud
Copy link
Contributor

@dllud dllud commented Jul 18, 2020

As asked by @bovine3dom at #2327
Suggestions are welcomed.

@@ -623,6 +623,8 @@ export class default_config {
* Examples:
* - When running `open gi cute puppies`, with a `gi` searchurl defined with `set searchurls.gi https://www.google.com/search?q=%s&tbm=isch`, tridactyl will navigate to `https://www.google.com/search?q=cute puppies&tbm=isch`.
* - When running `tabopen translate en ja Tridactyl`, with a `translate` searchurl defined with `set searchurls.translate https://translate.google.com/#view=home&op=translate&sl=%s1&tl=%s2&text=%s3`, tridactyl will navigate to `https://translate.google.com/#view=home&op=translate&sl=en&tl=ja&text=Tridactyl`.
*
* [[setnull]] can be used to "delete" the default search engines. E.g. `setnull searchurls.google`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the [[setnull]] linking syntax works across files, have you checked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used already like this, check line 803:

* Maps theme names to CSS. Predominantly used automatically by [[colourscheme]] to store themes read from disk, as documented by [[colourscheme]]. Setting this manually is untested but might work provided that [[colourscheme]] is then used to change the theme to the right theme name.

colourscheme is on another file, excmds.ts, the same as setnull.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea if that means that it works :)

I'll check next time I'm at a PC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahahah well, the colourscheme one definitely works. I clicked on it in my current Tridactyl installation.
I guess the setnull will work too: same syntax, same destination file.

@bovine3dom bovine3dom merged commit dae5b3b into tridactyl:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants