Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable passing in-memory LineDatabase to SpectrumGenerator #42

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Enable passing in-memory LineDatabase to SpectrumGenerator #42

merged 1 commit into from
Jul 20, 2018

Conversation

qobilidop
Copy link
Contributor

Currently this is possible in two steps:

sg = SpectrumGenerator('COS')
sg.line_database = ldb

It might be more convenient to do this in one step:

sg = SpectrumGenerator('COS', line_database=ldb)

chummels
chummels approved these changes Jul 20, 2018
View reviewed changes
Copy link
Collaborator

@chummels chummels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition here.

@chummels chummels merged commit a1d4c5e into trident-project:master Jul 20, 2018
@qobilidop qobilidop deleted the ldb branch July 25, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chummels chummels chummels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qobilidop @chummels