Issue 91 - Typo fix Wether / Overriden / Occured #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves having a map being passed in several places, making the code more readable and it also removes code duplication for generating the final output from the keyset. Switched to SHA256, as MD5 has been deprecated for any kind of use a long time ago. (and the overhead with current cpu's is so minimal that we really will not notice it).
This was referenced Feb 16, 2017
massar
changed the title
…gs, instead of having them hardcoded
Fix typo
Add iptrk_max, jwt_timeout and loginattempts_max configuration settings, instead of having them hardcoded
Move recover.tmpl from pitchfork to trident
Typo fix, Thanks!
Fix PGP download link
For tick/1961 - add ARF files as possible uploads to the wiki.
This includes some minor functionname changes & cleanups
…ections in fieldsets
This solves having a map being passed in several places, making the code more readable and it also removes code duplication for generating the final output from the keyset. Switched to SHA256, as MD5 has been deprecated for any kind of use a long time ago. (and the overhead with current cpu's is so minimal that we really will not notice it).
Primarily to make Golang Example for PageShow possible
We'll address this properly in #127
…for. Also makes searching for it easier in code and avoids confusion with HTTP headers, HTML headers (h1 etc) and others.
This solves having a map being passed in several places, making the code more readable and it also removes code duplication for generating the final output from the keyset. Switched to SHA256, as MD5 has been deprecated for any kind of use a long time ago. (and the overhead with current cpu's is so minimal that we really will not notice it).
2 statements with the same pfcol value are a bit confusing, may actually not work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #86, #87, #89 and #90; please merge those first, this will then be two teeny tiny commits.
This is for #91