Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test sudoers host_list and user_list #145

Merged
merged 6 commits into from
Mar 27, 2023
Merged

test sudoers host_list and user_list #145

merged 6 commits into from
Mar 27, 2023

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Mar 24, 2023

cc #96

@japaric japaric mentioned this pull request Mar 24, 2023
56 tasks
@japaric japaric changed the title test sudoers host_list test sudoers host_list and user_list Mar 24, 2023
@japaric japaric marked this pull request as ready for review March 24, 2023 17:48
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7c5a0cd) 67.85% compared to head (5bb5547) 67.85%.

❗ Current head 5bb5547 differs from pull request most recent head c30ec21. Consider uploading reports for the commit c30ec21 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   67.85%   67.85%           
=======================================
  Files          29       29           
  Lines        3232     3232           
=======================================
  Hits         2193     2193           
  Misses       1039     1039           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@squell squell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor comments but they only relate to comments and test case naming. Of course one thing that is still missing from these is the Host_Alias mechanism, but that can be a whole batch of test-case in itself.

squell and others added 2 commits March 27, 2023 15:53
Co-authored-by: Marc R. Schoolderman <4155359+squell@users.noreply.github.com>
@japaric japaric added this pull request to the merge queue Mar 27, 2023
Merged via the queue into main with commit 71b9dab Mar 27, 2023
@japaric japaric deleted the test-host-list branch March 27, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants