feat: support async io.runTask error callback

triggerdotdev · Feb 23, 2024 · b038719 · b038719
1 parent 07efef4
commit b038719
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/.changeset/chatty-trainers-happen.md b/.changeset/chatty-trainers-happen.md
@@ -0,0 +1,5 @@
+---
+"@trigger.dev/sdk": patch
+---
+
+support async `io.runTask` error callback
diff --git a/packages/trigger-sdk/src/io.ts b/packages/trigger-sdk/src/io.ts
@@ -80,16 +80,18 @@ type JsonArray = Json[];
 type JsonRecord<T> = { [Property in keyof T]: Json };
 export type Json<T = any> = JsonPrimitive | JsonArray | JsonRecord<T>;
 
-export type RunTaskErrorCallback = (
-  error: unknown,
-  task: IOTask,
-  io: IO
-) =>
+type RunTaskErrorCallbackReturn =
   | { retryAt?: Date; error?: Error; jitter?: number; skipRetrying?: boolean }
   | Error
   | undefined
   | void;
 
+export type RunTaskErrorCallback = (
+  error: unknown,
+  task: IOTask,
+  io: IO
+) => RunTaskErrorCallbackReturn | Promise<RunTaskErrorCallbackReturn>;
+
 export type IOStats = {
   initialCachedTasks: number;
   lazyLoadedCachedTasks: number;
@@ -1300,7 +1302,7 @@ export class IO {
 
         if (onError) {
           try {
-            const onErrorResult = onError(error, task, this);
+            const onErrorResult = await onError(error, task, this);
 
             if (onErrorResult) {
               if (onErrorResult instanceof Error) {