Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRI-1364] feat: Switch to Sonner toasts #555

Closed
ericallam opened this issue Oct 4, 2023 · 3 comments · Fixed by #600
Closed

[TRI-1364] feat: Switch to Sonner toasts #555

ericallam opened this issue Oct 4, 2023 · 3 comments · Fixed by #600
Labels
🎃 hacktoberfest 💎💎 250 points This issue is worth 250 points in the hacktoberfest leaderboard
Milestone
v.15

Comments

@ericallam
Copy link
Member

ericallam commented Oct 4, 2023 •
edited

We currently use toasts in our dashboard in a few places which are powered by "react-hot-toast". We should upgrade to Sonner toasts as they have some pretty cool features and look great:

https://github.com/emilkowalski/sonner

TRI-1364
@maige-app maige-app bot added enhancement New feature or request area/ux labels Oct 4, 2023
@ericallam ericallam changed the title feat: Switch to Sonner toasts [TRI-1364] feat: Switch to Sonner toasts Oct 4, 2023
@ericallam ericallam added 💎💎 250 points This issue is worth 250 points in the hacktoberfest leaderboard 🎃 hacktoberfest and removed enhancement New feature or request area/ux labels Oct 4, 2023
@gupta-piyush19
Copy link

Hi @ericallam! I'd like to work on this. Can you please assign this to me?

@Saurav-Pant
Copy link

I am interested in resolving this issue, please assign it to me @ericallam

@ericallam
Copy link
Member Author

We're not assigning issues, we'll accept the best PR for an issue (not necessarily the first PR either). Triaging assignments during hacktoberfest doesn't scale.

arjunindia added a commit to arjunindia/trigger.dev that referenced this issue Oct 4, 2023
@arjunindia
[TRI-1364] feat: Switch to Sonner toasts triggerdotdev#555
9870a4a
@arjunindia arjunindia mentioned this issue Oct 4, 2023
Closed
3 tasks
arjunindia added a commit to arjunindia/trigger.dev that referenced this issue Oct 6, 2023
@arjunindia
[TRI-1364] feat: Switch to Sonner toasts triggerdotdev#555
5135f11
@arjunindia arjunindia mentioned this issue Oct 10, 2023
Merged
3 tasks
@ericallam ericallam added this to the v.15 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎃 hacktoberfest 💎💎 250 points This issue is worth 250 points in the hacktoberfest leaderboard
Projects
None yet
Milestone
v.15
3 participants
@ericallam @gupta-piyush19 @Saurav-Pant