Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRI-1795] Add $not to eventFilters #810

Closed
matt-aitken opened this issue Dec 22, 2023 · 1 comment · Fixed by #815
Closed

[TRI-1795] Add $not to eventFilters #810

matt-aitken opened this issue Dec 22, 2023 · 1 comment · Fixed by #815
Milestone

Comments

@matt-aitken
Copy link
Member

matt-aitken commented Dec 22, 2023

EventFilters support lots of different nice matching, but they don't support not.

Add it to the schema:
https://github.com/triggerdotdev/trigger.dev/blob/main/packages/core/src/schemas/eventFilter.ts

Add the implementation:
https://github.com/triggerdotdev/trigger.dev/blob/main/packages/core/src/eventFilterMatches.ts

Add tests:
https://github.com/triggerdotdev/trigger.dev/blob/main/packages/core/test/eventFilterMatches.test.ts

TRI-1795

@matt-aitken matt-aitken changed the title Add $not to eventFilters [TRI-1795] Add $not to eventFilters Dec 22, 2023
@meetwithyash
Copy link
Contributor

@matt-aitken , Please review my PR for adding $not to eventFilters.

@matt-aitken matt-aitken added this to the v.27 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants