New TaskRunNumberCounter that uses taskIdentifier + environmentId #1124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where the task numbers were just looking at the taskIdentifier (the user-defined string in their tasks). This meant that if two tasks across different users had the same id (pretty likely) then the numbers wouldn't be correct.
This wasn't a security issue, it was purely used to increment the number for the TaskRun table. But obviously it's wrong so now the number is unique to the taskIdentifier + environmentId.