Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TaskRunNumberCounter that uses taskIdentifier + environmentId #1124

Merged
merged 3 commits into from
May 23, 2024

Conversation

matt-aitken
Copy link
Member

There was a bug where the task numbers were just looking at the taskIdentifier (the user-defined string in their tasks). This meant that if two tasks across different users had the same id (pretty likely) then the numbers wouldn't be correct.

This wasn't a security issue, it was purely used to increment the number for the TaskRun table. But obviously it's wrong so now the number is unique to the taskIdentifier + environmentId.

Copy link

changeset-bot bot commented May 23, 2024

⚠️ No Changeset found

Latest commit: a603bfe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matt-aitken matt-aitken merged commit 60cbb87 into main May 23, 2024
2 checks passed
@matt-aitken matt-aitken deleted the fixes/taskruncounter branch May 23, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants