This repository has been archived by the owner on Oct 12, 2021. It is now read-only.
Data conversion removed, CR Spec updated #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzununbekov
requested review from
cab105,
antoineco,
odacremolbap and
JeffNeff
…med to "Operation"
tzununbekov
force-pushed
the
formatting-fix
branch
from
b2bf8d5
to
91449e7
Compare
|
@JeffNeff please note that when it gets merged, current Transformation objects must be updated: after Sorry if it gives you too much of a headache, I should have renamed it before you started to work on Transformation Bridges |
|
No no! No headaches at all bud! Thank you for the heads up |
JeffNeff
reviewed
Sep 3, 2020
| // TryStringToJSONType accepts interface value and if value is string | ||
| // it will try to format it into JSON friendly representation of bool | ||
| // or float64. Otherwise value will be returned unchanged. | ||
| func TryStringToJSONType(value interface{}) interface{} { |
There was a problem hiding this comment.
ahhh... i see why we were getting that issue 😢. Thank you again for addressing this so quickly!
|
I saw that the README is outdated so I gave it a quick go over to try to be of a little help -> #26 |
|
LGTM. I am tying up some loose ends here and then im going to deploy it to a dev cluster and give it a poke or two for you. |
antoineco
approved these changes
Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23