Events sent only if Transformation succeeded #30

tzununbekov · 2020-09-18T15:34:13Z

strict Event type matching replaced with strings.Contains() method to support HTTPTarget headers (application/json; charset=utf-8 instead of just application/json),
errors returned from CE Receiver function (ceClient.StartReceiver(ctx, receiver)) are not honored and not logged; additional logging added inside the receiver function itself,
events that were not properly transformed due to the internal errors were sent back to the broker and eventually were looped because of the missing filtering attributes. This PR changes his behavior - events will be sent only if transformation succeed.

antoineco · 2020-09-18T16:31:53Z

pkg/transformer/transformer.go

+		log.Printf("Cannot encode CE context: %v", err)
+		return nil, fmt.Errorf("cannot encode CE context: %w", err)


Stupid SDK.

Do not send Event if transformation didn't succeed

a6b72fa

tzununbekov requested review from cab105, antoineco, odacremolbap and JeffNeff September 18, 2020 15:34

tzununbekov self-assigned this Sep 18, 2020

antoineco approved these changes Sep 18, 2020

View reviewed changes

cab105 approved these changes Sep 18, 2020

View reviewed changes

tzununbekov merged commit 99d8770 into master Sep 19, 2020

tzununbekov deleted the strict-err-handling branch September 19, 2020 10:39

Provide feedback

		log.Printf("Cannot encode CE context: %v", err)
		return nil, fmt.Errorf("cannot encode CE context: %w", err)