implement ci #57
implement ci #57
Conversation
sameersbn
force-pushed
the
add-ci
branch
2 times, most recently
from
a56d07b
to
915a923
Compare
Makefile
Outdated
| IMAGES = $(foreach r,$(RUNTIMES),$(r).image) | ||
| images: $(IMAGES) ## Build the Docker images | ||
| $(IMAGES): %.image: | ||
| @docker build -t $(IMAGE_REPO)/knative-lambda-$$(echo "$*" | sed -n -e "s/\([[:alnum:]]*\)\(-\)*\([0-9]*\)\(\.\)*\([0-9]*\)\(\.\)*\([0-9]*\).*/\1\3\5\7/p") $* |
There was a problem hiding this comment.
yea. it's a bit of a stretch.
We could get rid of the voodoo stuff if we just renamed the folders to their image names, f.e. python-2.7 -> python27
There was a problem hiding this comment.
renaming folders would require updates in several documents that refer to KLR runtime yaml files as well as in CLI bits that are also using KLR yamls. Maybe we could just list folders by their current names to avoid renaming?
There was a problem hiding this comment.
Maybe we could just list folders
do you mean link?
There was a problem hiding this comment.
nope, I need to think about what could be the solution, please don't merge yet. Although, maybe having the unified folder name structure actually worth updating all related docs and CLI.
There was a problem hiding this comment.
@tzununbekov i'll revert my folder renaming change.
There was a problem hiding this comment.
@tzununbekov i've reverted the folder rename change. please take a look
There was a problem hiding this comment.
well, the only possible way other than moving current paths is walking through the existing folders and grep-ing runtime.yaml for FROM gcr.io/triggermesh string to see which image is being used by the runtime. This also feels really hackish, so if we decide to go with the renaming approach, I will not argue - we'll just need to update a couple of files in the tm CLI and a bunch of them in the current repository.
There was a problem hiding this comment.
feels really hackish
That's true.
need to update a couple of files in the tm CLI and a bunch of them in the current repository.
I can work on this change. Are there any docs that would need updating?
There was a problem hiding this comment.
I think it would be easier for me to update those references. Give me 20 minutes, I'll link related PRs
sameersbn
force-pushed
the
add-ci
branch
3 times, most recently
from
5cc9dea
to
6f43244
Compare
|
@tzununbekov please take a look. updated the PR description to give an overview of the changes |
closes #52