Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

KLR runtime paths update #207

Merged
merged 2 commits into from Nov 25, 2020
Merged

KLR runtime paths update #207

merged 2 commits into from Nov 25, 2020

Conversation

tzununbekov
Copy link
Member

Links to KLR runtime.yaml files updated
Caused by triggermesh/knative-lambda-runtime#57

@tzununbekov tzununbekov self-assigned this Nov 24, 2020
README.md Show resolved Hide resolved
@tzununbekov
Copy link
Member Author

The test if failing because KLR runtime that the test depends on is not renamed yet

Copy link
Contributor

@sameersbn sameersbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameersbn
Copy link
Contributor

p.s. the directory rename is in effect. The tests on the PR are failing. Can you take a look please

@tzununbekov
Copy link
Member Author

tzununbekov commented Nov 25, 2020

some references in testfiles/broken-buildtemplate.yaml, namely https://github.com/triggermesh/tm/blob/master/testfiles/broken-buildtemplate.yaml#L48 and https://github.com/triggermesh/tm/blob/master/testfiles/broken-buildtemplate.yaml#L64 needs updating.

thanks for pointing this out, these test files are not in use anymore

upd: tests are still failing because of #208. We'll have to merge this one and then 208 to fix tests

@tzununbekov tzununbekov merged commit 01c3f46 into master Nov 25, 2020
@tzununbekov tzununbekov deleted the klr-links-update branch November 25, 2020 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants