-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lidar #1434
Merged
Merged
Lidar #1434
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ae00d83
Add lidar reading
IKhonakhbeeva 9bd3495
Add lidar as sensor
IKhonakhbeeva e3632ad
Simulate lidar
IKhonakhbeeva ce05fac
Add lidar emulation for trikbrick
IKhonakhbeeva a19dd7c
Fixes after review
IKhonakhbeeva 2590cbb
No need to reread sensor
IKhonakhbeeva e0f8500
Polish lidar working
IKhonakhbeeva e651dec
Add Read Lidar Block
IKhonakhbeeva 9acd4d4
Add Read Lidar block to palette
IKhonakhbeeva 6f6beac
Add generator for Read Lidar block
IKhonakhbeeva 18c29a8
Disable Read Lidar Block
IKhonakhbeeva f00bc1f
Need to draw image with real display width and hight
IKhonakhbeeva 39985bd
Lupdate
IKhonakhbeeva f07ae79
Fix build
IKhonakhbeeva 7b73225
Make Vera happy
IKhonakhbeeva 2931fee
Update Runtime
IKhonakhbeeva ef70a22
Make Vera happy
IKhonakhbeeva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
plugins/robots/common/kitBase/include/kitBase/robotModel/robotParts/lidarSensor.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* Copyright 2021 CyberTech Labs Ltd. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. */ | ||
|
||
#pragma once | ||
|
||
#include "vectorSensor.h" | ||
#include "kitBase/kitBaseDeclSpec.h" | ||
|
||
namespace kitBase { | ||
namespace robotModel { | ||
namespace robotParts { | ||
|
||
/// Base class for lidar sensors. | ||
class ROBOTS_KIT_BASE_EXPORT LidarSensor : public VectorSensor | ||
{ | ||
Q_OBJECT | ||
Q_CLASSINFO("name", "lidar") | ||
Q_CLASSINFO("friendlyName", tr("Lidar")) | ||
Q_CLASSINFO("simulated", "true") | ||
|
||
public: | ||
/// Constructor, takes device type info and port on which this sensor is configured. | ||
LidarSensor(const DeviceInfo &info, const PortInfo &port); | ||
}; | ||
|
||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
plugins/robots/common/kitBase/src/robotModel/robotParts/lidarSensor.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/* Copyright 2021 CyberTech Labs Ltd. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. */ | ||
|
||
#include "kitBase/robotModel/robotParts/lidarSensor.h" | ||
|
||
using namespace kitBase::robotModel; | ||
using namespace robotParts; | ||
|
||
LidarSensor::LidarSensor(const DeviceInfo &info, const PortInfo &port) | ||
: VectorSensor(info, port) | ||
{ | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
plugins/robots/common/twoDModel/include/twoDModel/robotModel/parts/lidar.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* Copyright 2021 CyberTech Labs Ltd. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. */ | ||
|
||
#pragma once | ||
|
||
#include <kitBase/robotModel/robotParts/lidarSensor.h> | ||
|
||
#include "twoDModel/twoDModelDeclSpec.h" | ||
|
||
namespace twoDModel { | ||
|
||
namespace engine { | ||
class TwoDModelEngineInterface; | ||
} | ||
|
||
namespace robotModel { | ||
namespace parts { | ||
|
||
/// 2D-model simulation of lidar. | ||
/// Configuration is perfomed immediately, the answer is ready immediately too. | ||
class TWO_D_MODEL_EXPORT Lidar : public kitBase::robotModel::robotParts::LidarSensor | ||
{ | ||
Q_OBJECT | ||
|
||
public: | ||
Lidar(const kitBase::robotModel::DeviceInfo &info | ||
, const kitBase::robotModel::PortInfo &port | ||
, engine::TwoDModelEngineInterface &engine | ||
, QPair<qreal, int> angleAndRange); | ||
|
||
void read() override; | ||
|
||
protected: | ||
engine::TwoDModelEngineInterface &mEngine; | ||
qreal mAngle; | ||
int mRange; | ||
}; | ||
|
||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
plugins/robots/common/twoDModel/src/robotModel/parts/lidar.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* Copyright 2021 CyberTech Labs Ltd. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. */ | ||
|
||
#include "twoDModel/robotModel/parts/lidar.h" | ||
|
||
#include "twoDModel/engine/twoDModelEngineInterface.h" | ||
|
||
using namespace twoDModel::robotModel::parts; | ||
using namespace kitBase::robotModel; | ||
|
||
Lidar::Lidar(const DeviceInfo &info, const PortInfo &port | ||
, engine::TwoDModelEngineInterface &engine, QPair<qreal, int> angleAndRange) | ||
: robotParts::LidarSensor(info, port) | ||
, mEngine(engine) | ||
, mAngle(angleAndRange.first) | ||
, mRange(angleAndRange.second) | ||
{ | ||
setLastData(QVector<int>(360, -1)); | ||
} | ||
|
||
void Lidar::read() | ||
{ | ||
setLastData(mEngine.readLidarSensor(port(), mRange, mAngle)); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
plugins/robots/generators/trik/trikPythonGeneratorLibrary/templates/sensors/lidar.t
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
brick.lidar("@@PORT@@").read() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
plugins/robots/generators/trik/trikQtsGeneratorLibrary/templates/sensors/lidar.t
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
brick.lidar(@@PORT@@).read() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А вместо этих
else if
нельзя возвращатьsensor->name()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нет, потому что sensor->name это что-то условно уникальное и характеризующее сам датчик, а те имена, что тут возвращаются, используются для выбора картинки, если ее не задали