-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teuchos: BLAS specify the return type of Complex blas calls #11010
Comments
@jjellio, the last commit I can find related to complex return times is dc26ca9 6 years ago. Looks the solution is to use Now that C++11 is required (for many years now), perhaps all of the BLAS and LAPACK wrappers that return complex types should just be hard-coded to use |
Oh interesting. So, this is a side effect of moving to CXX=14 or 17? I didn't realzie |
So weird,
That should be defining |
Configure Line
|
Or just take the ifdefs out all together and hard-code the branch that works with C++11+. There is actually a tool that will do that: unifdef. |
But why isn't it being defined? The logic should be defining it. And I agree - subtractive changes are as-good or better than additive. (e.g., let's delete things) - But it looks like something fundamental is wrong if that define is not present. |
Doh, I was confused.
It seems this could just be set to |
@bartlettroscoe this still hasn't gone through, and I don't think "RETEST" will fix it, as the problem appears to be perpetually broken tests. Is my read on this correct? Should we add retest? |
Question
@trilinos/teuchos
I've got alot of spam (warnings) about C-linkage and return values of complex blas functions. E.g.,
Is there a feature in Teuchos' wrappers that handles the return type better? I skimmed the code/cmake and didn't see anything. Intel discusses this, e.g., Calling complex blas through C++. And they aren't using the return value of the blas calls. I think Trilinos prefers to call the Fortran symbols directly, so it requires C-linkages for those.
@bartlettroscoe
The text was updated successfully, but these errors were encountered: