Warnings-as-errors need cleaned up #2284
Labels
Comments
prwolfe
added a commit
to prwolfe/Trilinos
that referenced
this issue
Mar 9, 2018
The tests were mostly signed/unsigned comparisons which I cast to match. I did consider changing the types, but other comparisons in the same code would have required a cast in the opposite direction so that was pointless. The example code was complaining about unused variables. I did lleave those in place but commented out so that the example is still there but the compiler does not complain. If someone wanted to instead use those in some way that would be good. closes issue trilinos#2284
9 tasks
|
2364 was merged via the ROL workflow and the build looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All three builds that use watnings-as-errors are showing 50+ failures. We need to look into these to support customers that use this. See https://testing.sandia.gov/cdash/index.php?project=Trilinos&parentid=3400360
@trilinos/rol 6 errors from 3 files
(packages/rol/test/function/constraint/test_03.cpp) from an unused variable.
(packages/rol/src/vector/ROL_PinTVector.hpp) from signed/unsigned comparison
(packages/rol/example/tempus/example_01.cpp) from unused variables.
Expectations
These warnings/errors should be resolved and the changes set as pull requests into develop to support Sierra and other codes. When those pull requests are merged the ticket should be closed.
Current Behavior
Warnings-as-errors builds fail on the above conditions
Motivation and Context
Definition of Done
Possible Solution
Steps to Reproduce
Your Environment
Related Issues
Additional Information
¯The text was updated successfully, but these errors were encountered: