ROL: correct warnings in examples and tests #2364

prwolfe · 2018-03-12T13:33:55Z

The tests were mostly signed/unsigned comparisons
which I cast to match. I did consider changing
the types, but other comparisons in the same code
would have required a cast in the opposite direction
so that was pointless. The example code was
complaining about unused variables. I did lleave those
in place but commented out so that the example is still
there but the compiler does not complain. If someone
wanted to instead use those in some way that would be good.

closes issue #2284

@trilinos/

Description

Motivation and Context

Related Issues

Closes
Blocks
Is blocked by
Follows
Precedes
Related to
Part of
Composed of

How Has This Been Tested?

Screenshots

Checklist

My commit messages mention the appropriate GitHub issue numbers.
My code follows the code style of the affected package(s).
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the code contribution guidelines for this project.
I have added tests to cover my changes.
All new and existing tests passed.
No new compiler warnings were introduced.
These changes break backwards compatibility.

Additional Information

The tests were mostly signed/unsigned comparisons which I cast to match. I did consider changing the types, but other comparisons in the same code would have required a cast in the opposite direction so that was pointless. The example code was complaining about unused variables. I did lleave those in place but commented out so that the example is still there but the compiler does not complain. If someone wanted to instead use those in some way that would be good. closes issue trilinos#2284

trilinos-autotester · 2018-03-12T13:46:21Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2018-03-12T13:52:51Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_autotester_test

Build Num: 476
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	2364
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	issue2284
TRILINOS_SOURCE_REPO	https://github.com/prwolfe/Trilinos
TRILINOS_SOURCE_SHA	`12df728`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6b31cd`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 341
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	2364
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	issue2284
TRILINOS_SOURCE_REPO	https://github.com/prwolfe/Trilinos
TRILINOS_SOURCE_SHA	`12df728`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6b31cd`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 58
Status: STARTED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	2364
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	issue2284
TRILINOS_SOURCE_REPO	https://github.com/prwolfe/Trilinos
TRILINOS_SOURCE_SHA	`12df728`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6b31cd`

Using Repos:

Repo: TRILINOS (prwolfe/Trilinos)

Pull Request Author: prwolfe

trilinos-autotester · 2018-03-12T15:20:57Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_autotester_test

Build Num: 476
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	2364
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	issue2284
TRILINOS_SOURCE_REPO	https://github.com/prwolfe/Trilinos
TRILINOS_SOURCE_SHA	`12df728`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6b31cd`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Build Num: 341
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.9.3
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	2364
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	issue2284
TRILINOS_SOURCE_REPO	https://github.com/prwolfe/Trilinos
TRILINOS_SOURCE_SHA	`12df728`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6b31cd`

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Build Num: 58
Status: PASSED

Jenkins Parameters

Parameter Name	Value
COMPILER_MODULE	sems-gcc/4.8.4
JENKINS_BUILD_TYPE	Release
JENKINS_COMM_TYPE	MPI
JENKINS_DO_COMPLEX	OFF
JENKINS_JOB_TYPE	Experimental
MPI_MODULE	sems-openmpi/1.8.7
PULLREQUESTNUM	2364
TEST_REPO_ALIAS	TRILINOS
TRILINOS_SOURCE_BRANCH	issue2284
TRILINOS_SOURCE_REPO	https://github.com/prwolfe/Trilinos
TRILINOS_SOURCE_SHA	`12df728`
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`c6b31cd`

trilinos-autotester · 2018-03-12T15:21:16Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

trilinos-autotester · 2018-03-12T15:21:22Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

mhoemmen · 2018-03-12T18:08:38Z

@prwolfe I created a ROL issue to mirror this PR: trilinos/trilinos.github.io#10

dridzal

In principle this looks fine, but I have a question. We would like to use more C++11 features in ROL, and have started converting some code to use 'auto', for example. Is there a cleaner way to fix these type mismatch issues by using 'auto'?

trilinos-autotester · 2018-03-12T19:23:42Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

trilinos-autotester · 2018-03-12T19:23:49Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

prwolfe · 2018-03-12T20:48:16Z

@dridzal - I am not sure that auto would help here as no matter what the compiler assigned at least one comparison would need a cast. In this case an unsigned int is being compared to both signed and unsigned int's. Nice idea otherwise (I have normally used this for pointers instead of integral types but it should work.)

gregvw · 2018-03-12T20:53:12Z

Warnings due to signed/unsigned comparisons have been an ongoing issue since there have been many instances in the code where containers like std::vector have been indexed with with int type (probably because ROL::Vector::dimension() returns int). The correct type for indexing is std::vector::size_type, which is unsigned and is the type that the size() method returns in the (for loop) comparisons. auto can be used to loop over vectors quite easily if you only want the elemental values and don't explicitly need the index.

You can do

for( auto element : myvector ) foo(element);

but something like

for( auto i=0; i<myvector.size(); ++i ) foo( myvector.at(i) );

doesn't solve the problem because the auto type deduction is set by the i=0 assignment which is still an int (you could do i=0u I guess).

A better approach if you are doing something where using the iterator would be clunky would be something like

using size_type = typename std::vector<ValueType,AllocatorType>::size_type;
for( size_type i=0; i<myvector.size(); ++i ) bar( myvector.at(i), i );

It would be nice to ultimately allow a generic integral type for dimension and basis.

I already pushed the unused warning fix for the tempus example_01 to the ROL dev fork last week.

Otherwise, these look fine to me.

dridzal · 2018-03-12T20:58:21Z

If @gregvw has already pushed these changes in the standalone ROL repo, then we may get a conflict when merging the ROL and Trilinos repos. To provide some background, ROL development takes place in a separate private github repo (essentially a snapshot of Trilinos), and we occasionally perform a two-way merge with Trilinos proper. Don't know how to proceed considering the potential merge conflict.

gregvw · 2018-03-12T21:00:58Z

Is there a "line item veto" for pull requests?

trilinos-autotester · 2018-03-12T21:03:40Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ dridzal ]!

trilinos-autotester · 2018-03-12T21:03:48Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

prwolfe · 2018-03-12T21:50:44Z

No line item veto that I know of. I have the PR open for editing by contributors if you wanted to do that, but if you are more comfortable pulling it into your workflow I am fine with that as long as it makes it's way into develop at some point.

mhoemmen · 2018-03-13T03:08:47Z

However you choose to do this, please please run with -Wall and fix the warnings :)

trilinos-autotester · 2018-03-13T21:06:37Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

gregvw

This looks ok to me. We can handle the merge conflict in the tempus example when we sync.

dridzal · 2018-03-13T21:29:48Z

I've applied the suggested changes directly to the code in the ROL repo, and am performing a sync with the Trilinos repo right now. If the sync succeeds, we can ignore the PR and close the issue.

mhoemmen · 2018-03-14T00:15:21Z

@gregvw If you know the right type, just use it for the index variable. Otherwise, use for (auto && x : getVector()) { /* ... */ }.

dridzal · 2018-03-14T01:04:08Z

The sync was successful. @prwolfe @mhoemmen How can we confirm that these warnings are gone? Is there a particular build on CDash to watch? Also, if the warnings are indeed gone, will closing this issue also delete the PR?

prwolfe · 2018-03-14T13:13:50Z

There is a build to watch and I looked this morning at https://testing.sandia.gov/cdash/index.php?project=Trilinos&parentid=3437562 and ROL is clean. I am abandoning and closing this and the issue as well.

Thanks!

prwolfe added the pkg: ROL label Mar 12, 2018

prwolfe self-assigned this Mar 12, 2018

prwolfe requested a review from eric-c-cyr March 12, 2018 13:33

bartlettroscoe added the stage: in progress Work on the issue has started label Mar 12, 2018

mhoemmen mentioned this pull request Mar 12, 2018

Correct warnings in examples and tests trilinos/trilinos.github.io#10

Closed

mhoemmen requested review from gregvw and dridzal March 12, 2018 18:10

dridzal reviewed Mar 12, 2018

View reviewed changes

dridzal approved these changes Mar 12, 2018

View reviewed changes

gregvw approved these changes Mar 13, 2018

View reviewed changes

prwolfe closed this Mar 14, 2018

bartlettroscoe removed the stage: in progress Work on the issue has started label Mar 14, 2018

prwolfe deleted the issue2284 branch April 19, 2018 13:06

ROL: correct warnings in examples and tests #2364

ROL: correct warnings in examples and tests #2364

Conversation

prwolfe commented Mar 12, 2018 • edited

Description

Motivation and Context

Related Issues

How Has This Been Tested?

Screenshots

Checklist

Additional Information

trilinos-autotester commented Mar 12, 2018

trilinos-autotester commented Mar 12, 2018

Build Information

Test Name: Trilinos_autotester_test

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

Using Repos:

trilinos-autotester commented Mar 12, 2018

Build Information

Test Name: Trilinos_autotester_test

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

Jenkins Parameters

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

Jenkins Parameters

trilinos-autotester commented Mar 12, 2018

trilinos-autotester commented Mar 12, 2018

mhoemmen commented Mar 12, 2018

dridzal left a comment

Choose a reason for hiding this comment

trilinos-autotester commented Mar 12, 2018

trilinos-autotester commented Mar 12, 2018

prwolfe commented Mar 12, 2018

gregvw commented Mar 12, 2018

dridzal commented Mar 12, 2018

gregvw commented Mar 12, 2018

trilinos-autotester commented Mar 12, 2018

trilinos-autotester commented Mar 12, 2018

prwolfe commented Mar 12, 2018

mhoemmen commented Mar 13, 2018

trilinos-autotester commented Mar 13, 2018

gregvw left a comment

Choose a reason for hiding this comment

dridzal commented Mar 13, 2018

mhoemmen commented Mar 14, 2018

dridzal commented Mar 14, 2018

prwolfe commented Mar 14, 2018

prwolfe commented Mar 12, 2018 •

edited