Apply Trilinos changes to accept updated TriBITS (TriBITSPub/TriBITS#299) #10504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riBITS#299) The updated version of TriBITS using modern CMake for TriBITSPub/TriBITS#299 creates a ${PACKAGE_NAME}_all_libs library target (used to create an ALIAS ${PACKAGE_NAME}::all_libs library target) from all of the targets under a package's base CMakeLists.txt file that don't have the TRIBITS_TESTONLY_LIB property set to TRUE. The tribits_add_library( ... TESTONLY ... ) function call automatically sets this property but if a package uses raw CMake to create targets (like Sacado is doing here with GoogleTest), then one must set the TRIBITS_TESTONLY_LIB property or one must create the ${PACKAGE_NAME}_all_libs and ${PACKAGE_NAME}::all_libs targets manually. Small price to pay on the path to making TriBITS more flexible and allowing raw CMake target formation.
bartlettroscoe
added
type: enhancement
|
@keitat, @ibaned, or @etphipp, Can one of you please approve this PR so it can be merged? Merging this will greatly simplify the process of testing updated versions of TriBITS 'master' with updated versions of Trilinos 'develop'. (I have a bunch of testing to do since I am about done with TriBITSPub/TriBITS#299 and I want try to catch issues before the updated TriBITS 'master' gets merged to Trilinos 'develop'.) |
bartlettroscoe
added
the
AT: AUTOMERGE
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: python-3
Jenkins Parameters
Build InformationTest Name: _cuda_10.1.243
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: python-3
Jenkins Parameters
Build InformationTest Name: _cuda_10.1.243
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
1 similar comment
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
etphipp
approved these changes
May 9, 2022
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ etphipp ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 10504: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
|
Thanks @etphipp! |
8 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the only change to Trilinos needed to accept the updated version of TriBITS. This is the only commit from PR #9978 needed to allow building Trilinos with updated versions of TriBITS 'master'.
Currently, this is a one-line change due to pulling in non-TriBITS targets through
add_subdirectory().I am creating this PR because we can't merge PR #9978 due to a break in backward compatibility with the move to modern CMake (see here). This will allow building Trilinos 'develop' against external TriBITS versions by just setting
Trilinos_TRIBITS_DIRat configure time. That is critical for testing updated versions of TriBITS.