Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Create new Astra/snl-arm ATDM env #6371

Closed
wants to merge 10 commits into from
Closed

WIP: Create new Astra/snl-arm ATDM env #6371

wants to merge 10 commits into from

Conversation

fryeguy52
Copy link
Contributor

@fryeguy52 fryeguy52 commented Nov 27, 2019 •
edited by bartlettroscoe
Loading

Add infrastructure to allow ATDM builds on arm machines

See CDOFA-27.

This PR replaces PR #5817 (which was @nmhamster's develop branch in his fork) ...

nmhamster and others added 8 commits August 29, 2019 10:17
@fryeguy52 fryeguy52 added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Nov 27, 2019
@bartlettroscoe bartlettroscoe mentioned this pull request Nov 27, 2019
Closed
@bartlettroscoe bartlettroscoe added ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: ATDM Any issue primarily impacting the ATDM project labels Nov 27, 2019
mhoemmen
mhoemmen approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

cmake/std/atdm/arm/environment.sh Outdated
@@ -0,0 +1,128 @@
################################################################################
#
# Set up env on a ARM ATSE builds of Trilinos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar is a bit off here.

cmake/std/atdm/arm/environment.sh Outdated
export ATDM_CONFIG_BUILD_COUNT=$ATDM_CONFIG_MAX_NUM_CORES_TO_USE
# NOTE: Use as many build processes and there are cores by default.

module purge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you would want to do this earlier, to avoid clobbering any of the above environment variables (just in case), but it shouldn't matter too much, I suppose.

cmake/std/atdm/arm/environment.sh Outdated

if [[ "$ATDM_CONFIG_NODE_TYPE" == "OPENMP" ]] ; then
export ATDM_CONFIG_CTEST_PARALLEL_LEVEL=$(($ATDM_CONFIG_MAX_NUM_CORES_TO_USE/2))
export OMP_NUM_THREADS=2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about ways to parameterize this in the future.

@bartlettroscoe
Switch from 'arm' to 'van1-tx2' and add custom_builds.sh
3ba5858
@bartlettroscoe
Eliminate SEMS 'ERROR: Unrecognized cluster <name>' output on unsuppo…
008c6b5 
…rted systems (CDOFA-27)

On the van1-tx2 machine 'stria', the sems get-platform file prints an error
message.  No sense in showing this error message in this context.
@bartlettroscoe bartlettroscoe self-assigned this Dec 3, 2019
@bartlettroscoe bartlettroscoe mentioned this pull request Jan 30, 2020
Closed
@bartlettroscoe
Copy link
Member

CC: @e10harvey

As described in ATDV-312, we are moving to a workflow where were shared and review new Trilinos branches internally and once they are reviewed and cleaned up there, then we will create a token Trilinos PR to get that branches merged to the external Trilinos GitHub 'develop' branch. For that, we have taken this branch and pushed it to the internal GitLab repo and create MR:

Therefore, I am closing this PR without merging and once the that internal branch is ready to go, we will open a new Trilinos Pull Request here.

@trilinos-autotester trilinos-autotester mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

Assignees

@e10harvey e10harvey

Labels
AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: ATDM Any issue primarily impacting the ATDM project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fryeguy52 @bartlettroscoe @mhoemmen @e10harvey @nmhamster