Allow socket usage in DATABASE_URL #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorint
reviewed
Mar 1, 2024
| @@ -155,6 +155,12 @@ def initialize_type_map(m) | |||
| end | |||
|
|
|||
| def initialize(connection, logger, connection_options, config) | |||
| config = config.dup | |||
|
|
|||
| # Trilogy ignores `socket` if `host is set. We want the opposite to allow | |||
There was a problem hiding this comment.
Missing a closing back-tick after "host". Should be:
# Trilogy ignores `socket` if `host` is set. We want the opposite to allow
There was a problem hiding this comment.
Anyway, I shouldn't worry -- the same typo is also in the original!
There was a problem hiding this comment.
I updated commit to fix the typo. Thanks for pointing this out!
lorint
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to mysql2, trilogy will ignore the socket config if host is set.
This makes it impossible to configure a UNIX domain socket connection via DATABASE_URL, as the URL must include a host.
This is a backport of rails/rails#50349