TrilogyAdapter: ignore host if socket is set #50349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to mysql2, trilogy will ignore the `socket` config if `host` is set. This makes it impossible to configure a UNIX domain socket connection via `DATABASE_URL`, as the URL must include a host.
casperisfine
force-pushed
the
trilogy-socket-conn
branch
from
f4a81c2
to
0fe087e
Compare
| @@ -76,6 +76,10 @@ def initialize_type_map(m) | |||
| def initialize(config, *) | |||
| config = config.dup | |||
|
|
|||
| # Trilogy ignore `socket` if `host is set. We want the opposite to allow | |||
There was a problem hiding this comment.
Suggested change
| # Trilogy ignore `socket` if `host is set. We want the opposite to allow | |
| # Trilogy ignores `socket` if `host` is set. We want the opposite to allow |
byroot
added a commit
that referenced
this pull request
Dec 13, 2023
TrilogyAdapter: ignore host if socket is set
|
Backported to 7-1-stable as 377650f (I consider this a bug given it's something that was possible with mysql2, but not trigloy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to mysql2, trilogy will ignore the
socketconfig ifhostis set.This makes it impossible to configure a UNIX domain socket connection via
DATABASE_URL, as the URL must include a host.