Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating toolbar #1956
Floating toolbar #1956
Changes from 13 commits
5ebaedd
4de8678
dbd79e6
ef7281f
e3c329a
3b63f29
a871a44
11dd62f
03409ec
0b1b1da
222edeb
b93eb60
b4780d5
b7d5aef
2ec4730
1567d88
339767b
d4ec3fe
a600757
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure text as context is approved at the moment. Is this a required use case for your scenario? Both the modus styleguide and the figma don't include text examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text buttons were discussed on the issue created for this component (#1420) multiple use cases were provided and it was approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sorina-ocheana I apologize, I did not update myself with the submitted issue. The decisions made in the ticket were not reflected in the areas I was told were the sources of truth. I will review the issue and adjust any comments accordingly as well as work internally to ensure we have a pathway to updating our sources of truth after decisions are made.