Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Docker build #86

Merged
merged 2 commits into from Dec 31, 2019
Merged

Fixes Docker build #86

merged 2 commits into from Dec 31, 2019

Conversation

spacelatte
Copy link
Contributor

docker build gave couple errors:

  • the subfinder got moved to new place
  • added geoip2 account details as build-arg
    also ignores failure if not provided (now requires sign up)

build.sh does not require cd

  • just give path to docker build context
  • also cd may echo directory due to CDPATH. suppress that.

@trimstray trimstray merged commit 4269f27 into trimstray:master Dec 31, 2019
@trimstray
Copy link
Owner

Thanks a lot, great PR! 🥇

@morawskim morawskim mentioned this pull request Jan 4, 2020
Closed
@PeterDaveHello PeterDaveHello mentioned this pull request Sep 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: High Status: Accepted Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spacelatte @trimstray