Support namespace specification #115
Conversation
|
@hashhar sorry to ask you but could you kindly review this, please...? 🙏 |
LittleWat
force-pushed
the
support-namespace-specification
branch
from
08e7cc1
to
ce8d856
Compare
|
This looks good to me. It would be good if we can document this as part of the frigate generated doc or maybe in a separate markdown file in a docs folder or so. Over time I want to get more docs in that folder and into a site |
|
Also maybe @radek-starburst @nineinchnick or @losipiuk can chime in. And @LittleWat I very much assume you tested and verified this already. |
LittleWat
force-pushed
the
support-namespace-specification
branch
from
ce8d856
to
c0093fd
Compare
|
@mosabua thank you for your review!
Yes, I've tested this on my Linux ec2 machine. It worked as expected.
Updated the README.md on how to use the helm template command by specifying the namespace! Could you review this again, please...? 🙏 |
|
Please rebase |
This PR attempts to close trinodb#114 This would be the standard way to support namespace specification.
LittleWat
force-pushed
the
support-namespace-specification
branch
from
c0093fd
to
d0ab859
Compare
|
@mosabua rebased! |
| @@ -3,6 +3,7 @@ apiVersion: autoscaling/v2 | |||
| kind: HorizontalPodAutoscaler | |||
| metadata: | |||
| name: {{ template "trino.worker" . }} | |||
| namespace: {{ .Release.Namespace }} | |||
There was a problem hiding this comment.
what happens if you do not specify namespace when installing helm? Will that resolve to default?
There was a problem hiding this comment.
I asked some clarifying questions in the issue: #114 (comment)
There was a problem hiding this comment.
Thank you for your reviews!
what happens if you do not specify namespace when installing helm? Will that resolve to default?
Yes, it will resolve to default namespace.
|
I think this is fine as long as we can get confirmation that this works transparently as before if no namespace parameter is passed in. I am not sure it does ... |
Thank you for your comment! if no namespace parameter is passed in, the namespace is set to |
This PR attempts to close #114
This would be the standard way to support namespace specification.